Support simple trial x-axis histogram label #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oeuftete
force-pushed
the
trial-x-axis-labelling
branch
from
ce15a9f
to
275c7bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 78.05% 78.39% +0.34%
==========================================
Files 16 16
Lines 1727 1722 -5
Branches 314 312 -2
==========================================
+ Hits 1348 1350 +2
+ Misses 323 311 -12
- Partials 56 61 +5
Continue to review full report at Codecov.
|
oeuftete
force-pushed
the
trial-x-axis-labelling
branch
from
275c7bc
to
47b4cae
Compare
oeuftete
changed the title
oeuftete
force-pushed
the
trial-x-axis-labelling
branch
from
47b4cae
to
c9c878f
Compare
|
This seems quite fine. You usually only have a single benchmark in your suite right? |
|
No, there were several benchmarks. |
|
Ah whoops, seems some conflicts appeared. Can you rebase over master? |
oeuftete
force-pushed
the
trial-x-axis-labelling
branch
from
c9c878f
to
4f5d8b4
Compare
|
I've moved on from this. Feel free to bring these commits in through your own branches. |
|
Rebased in 5478cb0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support simple trial x-axis histogram label, adding
trialto the--nameoption. Without this, there appears to be no way to generate histograms for long test names without having the x-axis labels take up a large amount of available real estate.TODO: