Skip to content

Commit

Permalink
fix(launch-review): Allow rating() callback to be invoked multiple ti…
Browse files Browse the repository at this point in the history
…mes (#3455)
  • Loading branch information
CalumMurray committed Jun 23, 2020
1 parent 2923504 commit 40b9295
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/@ionic-native/plugins/launch-review/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Injectable } from '@angular/core';
import { Cordova, IonicNativePlugin, Plugin } from '@ionic-native/core';
import { Observable } from 'rxjs';

/**
* @name Launch Review
Expand Down Expand Up @@ -55,10 +56,10 @@ export class LaunchReview extends IonicNativePlugin {
* - First: after `LaunchReview.rating()` is called and the request to show the dialog is successful. Will be passed the value `requested`.
* - Second: if and when the Rating dialog is actually displayed. Will be passed the value `shown`.
* - Third: if and when the Rating dialog is dismissed. Will be passed the value `dismissed`.
* @returns {Promise<string>}
* @returns {Observable<string>}
*/
@Cordova({ platforms: ['iOS'] })
rating(): Promise<string> {
@Cordova({ observable: true })
rating(): Observable<string> {
return;
}

Expand Down

0 comments on commit 40b9295

Please sign in to comment.