Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(network): bind listener to document instead of window (#2622)
We noticed that in some cases network state listeners are stopped triggering, but `navigator.onLine` still reflects the state correctly. I used the following code to debug and found out an issue with `window` and `document` difference: ```js window.addEventListener("online", ()=>console.warn('WINDOW ONLINE'), false); // won't be triggered window.addEventListener("online", ()=>console.warn('WINDOW ONLINE'), false); // won't be triggered document.addEventListener("online", ()=>console.warn('DOCUMENT ONLINE'), false); // triggered document.addEventListener("online", ()=>console.warn('DOCUMENT ONLINE'), false); // triggered ``` Also, according to plugin documentation, listeners should be bound to `document`: https://github.com/apache/cordova-plugin-network-information#offline
- Loading branch information