(feat): change iap2 for callbacks #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @thielCole |
ihadeed
added a commit
that referenced
this pull request
Jul 7, 2017
* initial commit for iap2 * fix(iap2): fix events callbacks (#1705) * fix(iap2): add missing decorator to register function (#1709) * (feat): change iap2 for callbacks * (fix): register cordova * (doc): updated docs with usage example (#1713) * (feat): change iap2 for callbacks * (fix): register cordova * (doc): adding setup for store
BuddyLReno
pushed a commit
to BuddyLReno/ionic-native
that referenced
this pull request
Aug 28, 2017
…#1775) * initial commit for iap2 * fix(iap2): fix events callbacks (danielsogl#1705) * fix(iap2): add missing decorator to register function (danielsogl#1709) * (feat): change iap2 for callbacks * (fix): register cordova * (doc): updated docs with usage example (danielsogl#1713) * (feat): change iap2 for callbacks * (fix): register cordova * (doc): adding setup for store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should change the IAPProductEvents to follow the documentation and allow callbacks in their place. The documentation for the original plugin was a bit complicated.
Didn't know what to do for the downloading callback. I haven't been able to test that piece.