refactor(push): update PushOptions interfaces to match new version #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihadeed
requested changes
Aug 23, 2017
| * PushOptions | ||
| */ | ||
| @Plugin({ | ||
| pluginName: 'Push', | ||
| plugin: 'phonegap-plugin-push', | ||
| pluginRef: 'PushNotification', | ||
| repo: 'https://github.com/phonegap/phonegap-plugin-push', | ||
| install: 'ionic cordova plugin add phonegap-plugin-push --variable SENDER_ID=XXXXXXXXX', | ||
| installVariables: ['SENDER_ID'], | ||
| install: 'ionic cordova plugin add phonegap-plugin-push', |
There was a problem hiding this comment.
This is not needed since we don't have variables anymore.
|
Please provide me with a link to verify these changes. PRs/commits/changelogs/docs would work. |
|
@ihadeed These changes won't work with plugin versions prior to phonegap-plugin-push@2.0.0, if you can, please let me know if there is anything I have to do about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.