Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP PATCH request #2052

Closed
irundaia opened this issue Oct 20, 2017 · 2 comments
Closed

HTTP PATCH request #2052

irundaia opened this issue Oct 20, 2017 · 2 comments

Comments

@irundaia
Copy link

irundaia commented Oct 20, 2017

I'm submitting a ... (check one with "x")
[ ] bug report
[x] feature request

Current behavior:
The ionic-native/http plugin does not support the PATCH HTTP method. I think it would be trivial to add it though. Would you be open for a PR?

  /**
   * Make a PATCH request
   * @param url {string} The url to send the request to
   * @param body {Object} The body of the request
   * @param headers {Object} The headers to set for this request
   * @returns {Promise<HTTPResponse>} returns a promise that resolve on success, and reject on failure
   */
  @Cordova()
  patch(url: string, body: any, headers: any): Promise<HTTPResponse> { return; }
ihadeed pushed a commit that referenced this issue Nov 9, 2017
* feat(http): add patch request support (#2052)

* feat(http): add "disableRedirect" support (#2022)

* fix(http): remove obsolete "validateDomainName" function (#2053)
@sykaeh
Copy link

sykaeh commented Nov 17, 2017

This issue has been resolved, hasn't it?

@irundaia
Copy link
Author

It seems like it has been. I’m closing thiis issue :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants