Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zeroconf): Adding reInit() method #2144

Merged
merged 1 commit into from
Dec 2, 2017
Merged

Conversation

emcniece
Copy link
Contributor

@emcniece emcniece commented Nov 24, 2017

Updates Zeroconf to version 1.3.0:

  • #50 (feat) Adds a reInit() method to remedy WiFi network changes while the app is running

Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR comment doesn't match PR changes:
The method is added, but otherwise there are no changes.
Bug or feature?

@emcniece
Copy link
Contributor Author

emcniece commented Dec 1, 2017

@janpio Thank you for the review!

This is a feature. The other two fixes were specific to becvert/cordova-plugin-zeroconf - I have removed them from the comment.

Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this is all good :)
🥇

@ihadeed ihadeed merged commit 7255795 into danielsogl:master Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants