Added wrapper for the Cordova OneSignal Plugin #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| options: { | ||
| googleProjectNumber: string, | ||
| autoRegister: boolean | ||
| }, object?: any): void { } |
There was a problem hiding this comment.
this function should be:
@Cordova()
static init(appId: string, options: { ... }): Promise<any> {return; }So just take out object?: any and set the return type to a promise, and add a return; to avoid any TypeScript errors.
The @Cordova() decorator would generate that promise, and attach the resolve to the third paramter automatically.
|
Hey there, Great work, thanks for submitting the PR! It just needs some simple fixes, see the comments I left on the code. |
|
Thanks for the feedback. Fixes are now commited :) |
|
Perfect! Thanks @Inoverse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OneSignal service is a provider for cloud messaging and push notifications. It has an official phonegap/cordova plugin but currently no Typescript support.
So I created a Ionic Native wrapper for this plugin with this PR.
OneSignal Website
OneSignal Cordova Documentation