Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web-intent add new Cordova Properties #2701

Closed
geferon opened this issue Sep 5, 2018 · 0 comments
Closed

Web-intent add new Cordova Properties #2701

geferon opened this issue Sep 5, 2018 · 0 comments

Comments

@geferon
Copy link

geferon commented Sep 5, 2018

I'm submitting a ... (check one with "x")
[ ] bug report
[X] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://ionicworldwide.herokuapp.com/

Current behavior:
None, as this is not a bug

Expected behavior:
Due to a recent update on the plugin darryncampbell-cordova-plugin-intent, and to also recent versions of Android, two new constant variables (Actions) have been added, this being ACTION_INSTALL_PACKAGE and ACTION_UNINSTALL_PACKAGE (as seen here).

Steps to reproduce:
None

Related code:
Plugin new constants: https://github.com/darryncampbell/darryncampbell-cordova-plugin-intent/blob/00f9f1e42381dc45c3d30310e647cbe26845e926/www/IntentShim.js#L18-L19

Only two new properties would be needed in the file: https://github.com/ionic-team/ionic-native/blob/master/src/%40ionic-native/plugins/web-intent/index.ts
which would be as following:

   /**
   * Convenience constant for actions
   * @type {string}
   */
  @CordovaProperty() ACTION_INSTALL_PACKAGE: string;
  
  /**
   * Convenience constant for actions
   * @type {string}
   */
  @CordovaProperty() ACTION_UNINSTALL_PACKAGE: string;

Other information:
None

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
I don't believe this would be needed but, anyways:

Ionic:

   ionic (Ionic CLI)          : 4.1.1 (C:\Users\Jorge\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.7
   @angular-devkit/core       : 0.7.5
   @angular-devkit/schematics : 0.7.5
   @angular/cli               : 6.1.5
   @ionic/ng-toolkit          : 1.0.7
   @ionic/schematics-angular  : 1.0.5

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : android 7.0.0, browser 5.0.3
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.2, cordova-plugin-ionic-webview 1.2.1, (and 19 other plugins)

System:

   Android SDK Tools : 26.1.1 (C:\Users\Jorge\AppData\Local\Android\Sdk)
   NodeJS            : v9.4.0 (C:\Program Files\nodejs\node.exe)
   npm               : 6.4.1
   OS                : Windows 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants