Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(janalytics): add plugin #2711

Merged
merged 4 commits into from Sep 15, 2018
Merged

feat(janalytics): add plugin #2711

merged 4 commits into from Sep 15, 2018

Conversation

artdong
Copy link
Contributor

@artdong artdong commented Sep 11, 2018

add janalytics native plugin

@danielsogl danielsogl self-assigned this Sep 11, 2018
@danielsogl danielsogl changed the title add janalytics native plugin feat(janalytics): add plugin Sep 11, 2018
@danielsogl danielsogl added new-plugin target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Sep 11, 2018
danielsogl
danielsogl requested changes Sep 15, 2018
View reviewed changes
Copy link
Owner

@danielsogl danielsogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the functions with jsdoc

@danielsogl
Copy link
Owner

I will merge your PR but I would appreciate if you could add the jsdoc in a separate PR.

@danielsogl danielsogl merged commit 0b97176 into danielsogl:master Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsogl danielsogl danielsogl requested changes

Assignees

@danielsogl danielsogl

Labels
new-plugin target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@artdong @danielsogl