Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createChannel doesnt support "vibration" option #2712

Closed
panchazo opened this issue Sep 11, 2018 · 0 comments
Closed

createChannel doesnt support "vibration" option #2712

panchazo opened this issue Sep 11, 2018 · 0 comments

Comments

@panchazo
Copy link

I'm submitting a ... (check one with "x")
[X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://ionicworldwide.herokuapp.com/

Current behavior:
createChannel doesnt support the vibration option that is documented at the push cordova plugin repo (https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/API.md#pushnotificationcreatechannel)

Expected behavior:
The implementation should support the vibration and the Channel interface should be declared as follows perhaps:

export interface Channel {
id: string;
description: string;
importance: Priority;
sound?: string;
vibration?: boolean | Array;
}

Steps to reproduce:
Check out the Channel interface located at index.d.ts (https://github.com/ionic-team/ionic-native/blob/master/src/%40ionic-native/plugins/push/index.ts) it lacks the vibration option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants