feat(crop): add crop plugin #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a useful plugin, but I haven't tested it myself. You have my vote, and those testing and using this plugin can help inform us on whether it's something we should support officially (by fixing the plugin, for example). |
|
Tested on Android 5 device, works great. I'll try to test on other devices when I get a chance. If anyone has any results please post here. |
|
Tested on Huawei P8 Lite (Android 6.0) and works great also. |
|
I say let's merge and we can iterate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin doesn't seem very stable, but we can add it if it's something people want.
Will leave this PR here and if we get lots of +1s we'll merge.
Repo is here: https://github.com/jeduan/cordova-plugin-crop