feat(inappbrowser): implement instance based wrapper #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihadeed
changed the title
| }) | ||
| static open(url: string, target?: string, options?: string): InAppBrowserRef { return; } | ||
|
|
||
| on(event: string): Observable<InAppBrowserEvent> { |
There was a problem hiding this comment.
What's the purpose of this function? Is this generic and something we could abstract for other plugins?
|
Looks like a nice improvement. Added a few comments on a few lines. Basically, it needs a simple usage comment and then I was confused by |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wrapper makes the inappbrowser instance based instead of being static.
The
.open()method that we currently have returnsInAppBrowserRefwhich had some functions that take callbacks as parameters. And since one of the major goals of ionic-native is to convert all callbacks to promises and observables, this wrapper seem to make more sense.I also added a fallback that will use
window.open()in a scenario wherecordovaorcordova.InAppBrowseris not available.Closes #247