Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(usabilla-cordova-sdk): add plugin #3362

Merged
merged 2 commits into from
Apr 17, 2020
Merged

feat(usabilla-cordova-sdk): add plugin #3362

merged 2 commits into from
Apr 17, 2020

Conversation

hiteshjain29
Copy link
Contributor

@hiteshjain29 hiteshjain29 commented Mar 31, 2020 •
edited
Loading

This adds an Ionic Native Wrapper for the cordova usabilla plugin. The plugin enables integration with the Usabilla sdk.

danielsogl
danielsogl requested changes Apr 15, 2020
View reviewed changes
Copy link
Owner

@danielsogl danielsogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add callback interfaces or set the return type to Promsie<void> if the callback is empty on all your functions.

@danielsogl danielsogl self-assigned this Apr 15, 2020
@danielsogl danielsogl added the target: minor This PR is targeted for the next minor release label Apr 15, 2020
@danielsogl danielsogl merged commit 9e2f670 into danielsogl:master Apr 17, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsogl danielsogl danielsogl approved these changes

Assignees

@danielsogl danielsogl

Labels
target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hiteshjain29 @danielsogl