Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fcm): add requestPushPermissionIOS and createNotificationChannelAndroid functions #3430

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

andrehtissot
Copy link
Contributor

Hi, I'm the maintainer of cordova-plugin-fcm-with-dependecy-updated and there are two methods of which the types are not available in @ionic-native/fcm.

I'm not so sure if it's correct. But the definition for the non-ionic methods are available as https://github.com/andrehtissot/cordova-plugin-fcm-with-dependecy-updated/blob/master/src/FCMPlugin.d.ts

@RichardBoyder
Copy link

@dotNetkow Or anyone able to look at this?

@RichardBoyder
Copy link

@IonicOnCouch @IonicProSupport Anyone able to Merge this for us please?

@danielsogl danielsogl changed the title Added two plugin methods requestPushPermissionIOS and createNotificationChannelAndroid feat(fcm): add requestPushPermissionIOS and createNotificationChannelAndroid functions Jun 11, 2020
@danielsogl danielsogl merged commit ef17dc5 into danielsogl:master Jun 11, 2020
@shprink
Copy link

shprink commented Sep 4, 2020

Hello @andrehtissot,
I have installed cordova-plugin-fcm-with-dependecy-updated v7.3.0 (the latest) and the API definition still does not include requestPushPermissionIOS or createNotificationChannelAndroid

image

The problem is that the latest ionic-native API has both already.

@andrehtissot
Copy link
Contributor Author

Hi @shprink

I really respect ionic's work on having these API descriptors.
But, the reality is that, having one repository describing another is very troublesome. Specially if the first has expectations with other dependencies as well.

For this reason and to have the freedom to change the API and have it supported right away for ionic users, the cordova-plugin-fcm-with-dependecy-updated plugin itself has it's methods definitions, even for specific ionic expectations, as described here https://github.com/andrehtissot/cordova-plugin-fcm-with-dependecy-updated#with-ionic

I want to thank for the work of others of this community, specially the maintainers of this repository, but it's much easier for all to keep it on one repository both functional and its description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants