Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for fixing missing methods issue #3491 #3517

Closed
wants to merge 19 commits into from
Closed

PR for fixing missing methods issue #3491 #3517

wants to merge 19 commits into from

Conversation

darshanclevertap
Copy link
Contributor

No description provided.

pwilkniss and others added 18 commits July 25, 2018 19:30
@pwilkniss
feat(clevertap): add CleverTap plugin
0fa6b38
@pwilkniss
style(clevertap): cleanup stray lint error
3fe6e40
@danielsogl
refactor
9f1e153
@darshanclevertap
Updating fork
3efacd7
@darshanclevertap
feat(clevertap): update for latest CleverTap Cordova plugin
9e41fdf
@SuryaClevertap
chore: Update Repo from Ionic Native Repo
a8669c8
@SuryaClevertap
fix: Code Changes for parity SDK-155
309dced
@SuryaClevertap
Merge branch 'master' into master
96d4efb
@SuryaClevertap
fix: Indentation fixes for SDK-155
02f6d93
@SuryaClevertap
fix: Code Repo fix while updating fork branch
90dfe4c
@SuryaClevertap
fix: Remove unnecessary adder .scripts Folder
ab8b859
@SuryaClevertap
fix: Remove unwanted added folder .circleci
64ffaae
@SuryaClevertap
fix: Remove unwanted added File .npmrc
56fd93d
@SuryaClevertap
fix: Revert .Github Folder Changes to as per Ionic-Native master
a8b20dd
@SuryaClevertap
fix: Update changes as per ionic-native master
5bf0d69
@SuryaClevertap
fix: Code Repo fix while updating fork branch
840a801 
fix: Remove unnecessary adder .scripts Folder

fix: Remove unwanted added folder .circleci

fix: Remove unwanted added File .npmrc

fix: Revert .Github Folder Changes to as per Ionic-Native master

fix: Update changes as per ionic-native master
@SuryaClevertap
Merge branch 'master' of https://github.com/CleverTap/ionic-native
ca1a92e
@darshanclevertap
fix(CleverTap): Fix for missing methods issue danielsogl#3491
7012870
@darshanclevertap
Copy link
Contributor Author

@danielsogl Can someone help here?

@darshanclevertap
Copy link
Contributor Author

@danielsogl Our clients are waiting for this release. Can we get some response at least? Some sort of an ETA on when will these changes be merged?

@mhartington
Copy link
Contributor

@darshanclevertap can you rebase your commits instead of just merging in the changes? The commit history looks a bit messy here.

Also, Ionic native is community driven, meaning people help out when they can. You do not need to ping Daniel to get his attention.

Clean up the commit history, and it should be good to go from there.

@darshanclevertap
Copy link
Contributor Author

@mhartington Thanks for reaching out. I've updated the code, tried to rebase the commits as well, not sure what was expected of me. Do I need to squash merging commits or just a normal git rebase -r ?

@darshanclevertap
Copy link
Contributor Author

@mhartington Any update here?

@darshanclevertap
Copy link
Contributor Author

@mhartington Can we close this soon?

@mhartington
Copy link
Contributor

Is the PR correct? Just removing 4 methods from the plugin? initializeInbox, getInboxMessageUnreadCount, getInboxMessageCount, and showInbox?

@darshanclevertap
Copy link
Contributor Author

@mhartington Yes, because they were added twice and because of this the methods were unusable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@darshanclevertap @mhartington @pwilkniss @danielsogl @SuryaClevertap