Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic-native@1.3.24 is throwing TypeScript errors #567

Closed
dlemphers opened this issue Sep 21, 2016 · 30 comments
Closed

ionic-native@1.3.24 is throwing TypeScript errors #567

dlemphers opened this issue Sep 21, 2016 · 30 comments
Assignees

Comments

@dlemphers
Copy link

image

@cmaart
Copy link

cmaart commented Sep 22, 2016

Yep, can confirm

@lukeisontheroad
Copy link

Same here

@ezekjh
Copy link

ezekjh commented Sep 22, 2016

Yup, having the same issue. Had to go back a version..

@nachofregeiro
Copy link

I'm experiencing the same issue.

@ferminmoli
Copy link

The same is happening here!

@FdezRomero
Copy link
Contributor

Also getting broken builds... I'm not going to complain, but something should be done to avoid breaking the package on ionic-native@latest 😭

@mhartington
Copy link
Contributor

thanks for letting us know. We'll be looking into.

Please refrain from adding "same here"

@mhartington
Copy link
Contributor

@dlemphers is this an ionic 1 project or ionic 2? Also, what's your installed typescript version?

tsc -v

@mlynch
Copy link
Collaborator

mlynch commented Sep 22, 2016

I wonder if this is related to moving from typescript 1.8.10 to 2.0.2 7f77b8f

@mlynch
Copy link
Collaborator

mlynch commented Sep 22, 2016

Hey all, please check your typescript version and update to 2.0.x if you haven't. We recently moved so the declaration files now require 2.0. In the meantime we'll check for a better backwards compat solution

@mhartington mhartington self-assigned this Sep 22, 2016
@mlynch
Copy link
Collaborator

mlynch commented Sep 22, 2016

Okay, I'm reverting my changes that used typescript 2.0, going to publish a fixed 1.3.25, then will publish a 2.0.0 with typescript 2.0. Stand by

@mlynch
Copy link
Collaborator

mlynch commented Sep 22, 2016

Okay, fix landed. Can you all try 1.3.25?

@mlynch mlynch closed this as completed Sep 22, 2016
@nachofregeiro
Copy link

I updated to 1.3.25 and still having the same issue.

@FdezRomero
Copy link
Contributor

Hi Max, I installed 1.3.25 and the previous errors are gone but got a new one. It seems that something might be missing in the export:

TypeScript error: app/app.ts(5,39): Error TS2307: Cannot find module 'ionic-native'.

Thanks for checking this and sorry Mike if I disturbed you before, it wasn't my intention.

@mlynch
Copy link
Collaborator

mlynch commented Sep 22, 2016

@nachofregeiro are you seeing the exact issue or are you seeing what @FdezRomero sees? Also try nuking your ionic-native node modules dir first

@nachofregeiro
Copy link

Same as him: Error TS2307: Cannot find module 'ionic-native'.

Latest version working for me is 1.3.21.

@mlynch
Copy link
Collaborator

mlynch commented Sep 22, 2016

Thanks. So a different issue :D

Are you guys testing in an Ionic app? If so, what version?

@FdezRomero
Copy link
Contributor

Cordova CLI: 6.3.1
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.0.0
Ionic App Lib Version: 2.0.0
ios-deploy version: 1.9.0
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v4.5.0
Xcode version: Xcode 8.0 Build version 8A218a

@nachofregeiro
Copy link

Cordova CLI: 6.2.0
Gulp version: CLI version 1.2.1
Gulp local: Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.1.0-beta.1
Ionic App Lib Version: 2.1.0-beta.0
OS:
Node Version: v5.12.0

@mlynch mlynch reopened this Sep 22, 2016
@mlynch
Copy link
Collaborator

mlynch commented Sep 22, 2016

thanks, I think I see the issue here, pushing a fix now

@mlynch
Copy link
Collaborator

mlynch commented Sep 22, 2016

Okay, I think it's fixed now. can you try 1.3.27?

@nachofregeiro
Copy link

1.3.27 is working! Awesome job! Thanks for helping us.

@mlynch
Copy link
Collaborator

mlynch commented Sep 22, 2016

giphy 2

@mlynch mlynch closed this as completed Sep 22, 2016
@owlcode
Copy link

owlcode commented Sep 26, 2016

After upgrading to 2.0.3 I'm still having this issue

Cordova CLI: 6.3.0
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.0.0-beta.35
Ionic App Lib Version: 2.0.0-beta.19
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v6.3.1
Xcode version: Xcode 8.0 Build version 8A218a

tsc -v
Version 2.0.0

@nachofregeiro
Copy link

If you are using ionic-gulp-browserify-typescript, you may be still using tsify 0.14.8 and typescript 1.8.10 even if you globally installed typescript 2.0.

@owlcode
Copy link

owlcode commented Sep 26, 2016

I reinstalled these packages (npm remove & npm install) and it still doesn't work. In my package.json I have

"ionic-gulp-browserify-typescript": "2.0.0",
"tsify": "^1.0.7",
"typescript": "^2.0.3",
"ionic-native": "2.0.3"

@nachofregeiro
Copy link

Do npm list and check this:

+-- ionic-gulp-browserify-typescript@2.0.0
| `-- tsify@0.14.8
|   +-- debuglog@1.0.1
|   `-- typescript@1.8.10

@mlynch
Copy link
Collaborator

mlynch commented Sep 26, 2016

Currently that script uses an old version of typescript. We're going to be rolling out beta.12 this week with some other changes and that supports TS 2.0

@owlcode
Copy link

owlcode commented Sep 26, 2016

Ok, thank you 👍

@pablomaurer
Copy link

Just throwing it in
http://stackoverflow.com/questions/41301465/typescript-tricky-module-not-found-error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests