fix(googlemaps): typo in GoogleMapsTileOverlayOptions #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the first version exists typo https://github.com/driftyco/ionic-native/blob/55a7f1f3774d834803b5fc09648a01fd78e173c2/src/plugins/googlemaps.ts we have to test suite with urgently Thanks |
|
@ramonornela How can I help you? Unit tests? |
|
Try to works in an proposal later @SylvainGuittard , after integration this has need effort to write tests all Thanks |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to my first PR (#580) and this issue: #579
The commit (f36b1c0) does not fix the issue.