Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPlayer VideoOptions.scalingMode incorrect type. Should #774

Closed
cnanders opened this issue Nov 4, 2016 · 1 comment
Closed

VideoPlayer VideoOptions.scalingMode incorrect type. Should #774

cnanders opened this issue Nov 4, 2016 · 1 comment

Comments

@cnanders
Copy link

cnanders commented Nov 4, 2016

Per the spec,

https://developer.android.com/reference/android/media/MediaPlayer.html#VIDEO_SCALING_MODE_SCALE_TO_FIT_WITH_CROPPING

VIDEO_SCALING_MODE_SCALE_TO_FIT and
VIDEO_SCALING_MODE_SCALE_TO_FIT_WITH_CROPPING

return Int.

By setting the VideoOptions interface with scalingMode having type "String", it is impossible to actually set the scaling mode using ionic-native's wrapper for the VideoPlayer plugin.

Please change this to type "int" and export two static properties of VideoPlayer player

VideoPlayer.SCALING_MODE_SCALE_TO_FIT: int = 1
VideoPlayer.SCALING_MODE_SCALE_TO_FIT_WITH_CROPPING: int = 2

@ihadeed
Copy link
Collaborator

ihadeed commented Nov 23, 2016

Thanks just fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants