Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: NativeAudio play documentation incorrect #792

Closed
dylanvdmerwe opened this issue Nov 14, 2016 · 1 comment
Closed

docs: NativeAudio play documentation incorrect #792

dylanvdmerwe opened this issue Nov 14, 2016 · 1 comment

Comments

@dylanvdmerwe
Copy link
Contributor

For the NativeAudio plugin, the example says you use the play method like:

NativeAudio.play('uniqueId1').then(onSuccess, onError);

However this is not correct as later on in the docs (and in the TypeScript definitions) the play method takes an additional callback.

play(id, completeCallback)

http://ionicframework.com/docs/v2/native/nativeaudio/

@ihadeed
Copy link
Collaborator

ihadeed commented Nov 23, 2016

Thanks

The callback is actually optional. I just fixed the typing and updated the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants