Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reaload issue #101

Closed
liugangnhm opened this issue Feb 13, 2020 · 3 comments
Closed

Hot reaload issue #101

liugangnhm opened this issue Feb 13, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@liugangnhm
Copy link

Describe the bug

when i use following code ,hot reload not work, button text not change when model.reading has been changed

GFButton(
                    child: model.reading ? Text('Stop') : Text('Continuous'),
                    onPressed: () async {
                      if (!model.reading) {
                        await model.startInventory();
                      } else {
                        await model.stopInventory();
                      }
                    },
                  ),

i must set a key for that to work

GFButton(
                    key: ValueKey(model.reading),
                    //text: model.reading ? 'Stop' : 'Continuous',
                    child: model.reading ? Text('Stop') : Text('Continuous'),
                    onPressed: () async {
                      if (!model.reading) {
                        await model.startInventory();
                      } else {
                        await model.stopInventory();
                      }
                    },
                  ),

is that expected?

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Sandipkakadiya
Copy link
Member

Hi liugangnhm.

Thanks for submitting issue.
We are looking at the issue we will release new version with the fix ASAP possible.

@pietechsolution pietechsolution added the bug Something isn't working label Feb 14, 2020
@Sandipkakadiya
Copy link
Member

New version has been released. it includes fixes of hot reload issue mentioned above.
Please use version getflutter: ^1.0.8 or above.

@liugangnhm
Copy link
Author

thanks. this issue seems to be fixed but getting another hot reload issue . I will close this issue and open a new one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants