Script checker options need to inject best version of FSharp.Core found

[rneatherway]

See fsharp/fsharp-compiler-docs#384

Related to #42, for supporting VS2015 and MSBuild > 12.

The script checker options will default to the version of FSharp.Core used by FSAC, which is FSharp.Core 4.3.0.0. So this is already a minor issue w.r.t. F# 3.1/ FSharp.Core 4.3.1.0.

[7sharp9]

Could you keep me posted so I can get a potential fix into XS? Better yet a PR :-)

[rneatherway]

Yes, I'm waiting to see how @dungpa handles it, then I'll see if I can push it into FCS.

[dungpa]

Here is the logic I used dungpa/PowerTools@16dc45e It uses registry readers already available in CompilerLocationUtils.fs.

[7sharp9]

So in mono how would that work, the registry is not used.

On 2 Aug 2015, at 14:09, Anh-Dung Phan notifications@github.com wrote:

Here is the logic I used dungpa/PowerTools@16dc45e It use registry readers already available in CompilerLocationUtils.fs.

—
Reply to this email directly or view it on GitHub.

[rneatherway]

For VFPT mono isn't important, we'll need a different approach.

[rneatherway]

Easiest resolution for this will be to just ship FSharp.Core 4.4

[7sharp9]

Note: most of CompilerLocationUtils.fs is now depreciated.

[rneatherway]

Good to know, because I have a wanted to delete it for ages!

[rneatherway]

@dungpa: I was just looking at this to see how you actually detect the Visual Studio version and it looks hardcoded to VS2013 for scripts. Does that get overridden somewhere that I'm not seeing?

[rneatherway]

Just a note that upgrading to FSharp.Core 4.4.0.0 did not help. FCS always returns a reference of "FSharp.Core.dll" on Mono: https://github.com/dsyme/FSharp.Compiler.Service/blob/c5a64b00bdd645e7505dea6879673615a05df3ae/src/fsharp/build.fs#L1560

[dungpa]

@rneatherway That part is used in unit testing only. We pass the Visual Studio version at https://github.com/dungpa/PowerTools/blob/dfbd8cc1c02264db883b358b10c25e97c2b84e1f/src/FSharpVSPowerTools.Logic/ProjectFactory.fs#L161-L162.

[rneatherway]

Ah right, of course VS will tell you! Thanks.

[rneatherway]

VS2012:

fsc.exe found at 'C:\Program Files (x86)\Microsoft SDKs\F#\3.1\Framework\v4.0\fsc.exe'
FSharp.Core found at 'C:\Program Files (x86)\Reference Assemblies\Microsoft\FSharp.NETFramework\v4.0\4.3.1.0\FSharp.Core.dll'
msbuild.exe found at 'C:\Program Files (x86)\MSBuild\12.0\Bin\MSBuild.exe'

VS2015:

fsc.exe found at 'C:\Program Files (x86)\Microsoft SDKs\F#\4.0\Framework\v4.0\fsc.exe'
FSharp.Core found at 'C:\Program Files (x86)\Reference Assemblies\Microsoft\FSharp.NETFramework\v4.0\4.4.0.0\FSharp.Core.dll'
msbuild.exe found at 'C:\Program Files (x86)\MSBuild\14.0\Bin\MSBuild.exe'

[rneatherway]

(for reference)

[rneatherway]

Fixed by #59

[monkieboy]

@7sharp9 @rneatherway I know this is closed but I am experiencing the same thing with Xamarin Studio. Is the fix out yet? Can I do anything to fix this myself?