Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space after a closing *) literate comment breaks ionide highlighting #166

Closed
nhirschey opened this issue Feb 24, 2022 · 0 comments · Fixed by #167
Closed

Space after a closing *) literate comment breaks ionide highlighting #166

nhirschey opened this issue Feb 24, 2022 · 0 comments · Fixed by #167

Comments

@nhirschey
Copy link
Contributor

Describe the bug
I recently noticed that syntax highlighting for some of my FSharp.Formatting scripts seemed broken.

I found that a space after a closing "*)" markdown comment broke syntax highlighting.

Is the possible problem this line?

ionide-fsgrammar/grammars/fsharp.json

Line 539 in 3311701

"while": "^(?!\\s*(\\*)+\\)$)",

Would allowing whitespace between \\) and $ at the end fix this?

To Reproduce

bad-highlight

Expected behaviour
I do not expect a space at the end of a comment to break syntax highlighting.

Environment (please complete the following information):

  • OS: Windows_NT x64 10.0.22000
  • Ionide version: 5.11
  • VSCode version: 1.64.2 (user setup)
  • dotnet SDK version: 6.0.200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow white space after ending markdown comment. nhirschey/ionide-fsgrammar
1 participant
@nhirschey