-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have an option to make Ionide "silent" #1077
Comments
In this case it should be shown front and centre - not hidden per the screenshot but a big button next to Show status and the default button. Personally I would rather just remove it completely at the moment - it's shown so often I have no trust in it any more that the project is "really" broken or just Ionide being overly chatty. |
I agree that the current status where a simple I'd very much prefer status bar indicators (like omnisharp) for solution/project/file. |
@vbfox it's actually worse than useless - people see it and think that Ionide (or worse just F# in general) simply is broken. I'm seeing this with virtually every new person to F# that tries Ionide - it reduces confidence and people think that the tech is broken. Is there a way to turn off this warning and push out a new release of Ionide with that in @Krzysztof-Cieslak ? |
I'm still on the fence with that. Without notification people will complain that Ionide is not working and they don't know why - this at least attempts to put in their face detailed error message that they can use to debug problem instead of just crying everywhere that Ionide is broken. |
After working on the other issue ("file not in any project" warning) I think it's a big problem and shouldn't be there in this form. Not the error/warning itself but the vscode notification. It has an enormous problem of timing
Essentially I think it should be replaced by a second indicator in the status bar showing the current workspace status (Just near the current project one), and potentially delaying status changes for 1s or 2s to ensure that the status is stable. Ideally clicking on it would lead somewhere that indicate what's wrong in the workspace |
I think we can do that. |
If it's set/cleared correctly Ionide could also report an error in the csproj file using the normal VSCode error reporting. It'll make the file red in the file list providing another location where the user can find why his project doesn't work |
@Krzysztof-Cieslak that's true, but the problem is that there are way, way more false positives than real project errors. So people just dismiss the warning and then when a "real" error comes up, they don't believe it. So the real purpose that you're (rightly) aiming for is unfortunately being lost. |
Fixed by 66118a5 |
At least until Ionide doesn't show project parse failures on opening solutions that e.g. don't have packages restored (or at other random times), I think Ionide should either stop showing the notifications or at least have an option to stop showing them. 9/10 times they don't provide any value since they fix themselves on a build, and instead they give the impression that F# / VS Code / Ionide is somehow broken.
The text was updated successfully, but these errors were encountered: