From time "StackOverflowException" while trying to load project

[matthid]

[11:01:56 ERROR] Project loading failed, error parsing ProjectCrackerTool output, stdoutput was:

stderr was:

Process is terminated due to StackOverflowException.

The project is a new-style SDK project, which looks like (names changed):

<Project>
  <Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" />
  <PropertyGroup>
    <AssemblyName>Server</AssemblyName>
    <OutputType>Exe</OutputType>
    <TargetFramework>net461</TargetFramework>
    <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
  </PropertyGroup>
  <ItemGroup>
    <ProjectReference Include="..\Services\Services.Service\Services.Service.fsproj">
      <Private>True</Private>
    </ProjectReference>
    <ProjectReference Include="..\Services\Services.Messages.CSharp\Services.Messages.CSharp.csproj">
      <Private>True</Private>
    </ProjectReference>
  </ItemGroup>
  <ItemGroup>
    <Compile Include="../Shared/Shared.fs" />
    <Compile Include="../Shared/MiddlewareState.fs" />
    <Compile Include="basicAuth/BasicAuthentication.fs" />
    <Content Include="appsettings.json">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </Content>
    <Content Include="Resources/localization_de.json">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </Content>
    <Content Include="Resources/localization_en.json">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </Content>
    <Compile Include="ClientLogBatchProcessor.fs" />
    <Compile Include="Handler.fs" />
    <Compile Include="Startup.fs" />
    <Compile Include="Program.fs" />
    <None Include="paket.references" />
  </ItemGroup>
  <ItemGroup>
    <Reference Include="System.Web" />
  </ItemGroup>
  <Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" />
  <Target Name="Pack" />
  <Import Project="..\..\.paket\Paket.Restore.targets" />
</Project>

I thought the project cracker is not used for new-style sdk projects?

[matthid]

One other thing I noticed (and might be related). If the project looks like this:

<Project>
  <PropertyGroup>
    <AssemblyName>Server</AssemblyName>
    <OutputType>Exe</OutputType>
    <TargetFramework>net461</TargetFramework>
    <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
  </PropertyGroup>
  <ItemGroup>
    <ProjectReference Include="..\Services\Services.Service\Services.Service.fsproj">
      <Private>True</Private>
    </ProjectReference>
    <ProjectReference Include="..\Services\Services.Messages.CSharp\Services.Messages.CSharp.csproj">
      <Private>True</Private>
    </ProjectReference>
  </ItemGroup>
  <ItemGroup>
    <Compile Include="../Shared/Shared.fs" />
    <Compile Include="../Shared/MiddlewareState.fs" />
    <Compile Include="basicAuth/BasicAuthentication.fs" />
    <Content Include="appsettings.json">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </Content>
    <Content Include="Resources/localization_de.json">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </Content>
    <Content Include="Resources/localization_en.json">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </Content>
    <Compile Include="ClientLogBatchProcessor.fs" />
    <Compile Include="Handler.fs" />
    <Compile Include="Startup.fs" />
    <Compile Include="Program.fs" />
    <None Include="paket.references" />
  </ItemGroup>
  <ItemGroup>
    <Reference Include="System.Web" />
  </ItemGroup>
  <Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" />
  <Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" />
  <Target Name="Pack" />
  <Import Project="..\..\.paket\Paket.Restore.targets" />
</Project>

(Notice the moved props import) then it doesn't load at all apparently. It builds and runs fine on the command line last time I checked.

[matthid]

Let me know if I can enable more logs somewhere, I haven't found anything else regarding logs or hints myself.

[MangelMaxime]

I don't know if this will contains logs about ProjectCrackerTool but in Ionide you can do:

1. Ctrp + P > F#: Toggle Diagnostic
2. Ctrp + P > Reload window
3. Ctrp + P > F#: Get Ionide logs

[matthid]

Thanks, problem is the logfile contains source code, so I can only share privately. Also the error is not reproducible every time apparently, now I have a different one where it stays on loading.. forever. But there is always something wrong in this solution.

[MangelMaxime]

Ah yes, we spoke about removing the code from the logs but never implemented it... Will add it to my todo :)

[MangelMaxime]

In theory the logs should not include source code. We are not logging the parse command. Source

[matthid]

Well, I see source code in the logfile ;)

[Krzysztof-Cieslak]

What's weird about it is that your project is SDK based, and the exception mentions ProjectCracker which should never be used with SDK based project files. Is one of the referenced projects non-SDK one?

[Krzysztof-Cieslak]

Hmm...Ignore previous message... I think there is something that I don't know going on here. Doesn't most SDK projects have <Project Sdk="Microsoft.NET.Sdk"> as a first list? And what are <Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" /> and <Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" /> ? :-)

We probably don't detect it as SDK project, and try to crack it with ProjectCrapper, which obviously fails.

[Krzysztof-Cieslak]

Yeah, it seems to be a case - check FSAC project type classification here - https://github.com/fsharp/FsAutoComplete/blob/master/src/FsAutoComplete.Core/ProjectCrackerTypes.fs#L67-L89

[matthid]

Is one of the referenced projects non-SDK one?

Indeed. In fact I would be happy if I could just disable that ionide is trying to load those...

don't detect it as SDK project,

Actually, that probably/hopefully explains a lot of weirdness I'm encountering with ionide. I often change the project file as shown above because you can overwrite sdk targets by importing the sdk in this explicit form...