Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine client sid issue #37

Closed
manishiitg opened this issue May 24, 2021 · 1 comment
Closed

engine client sid issue #37

manishiitg opened this issue May 24, 2021 · 1 comment

Comments

@manishiitg
Copy link

Your environment.

  • Version: Release or SHA
  • Browser: include version
  • Other Information - stacktraces, related issues, suggestions how to fix, links for us to have context

What did you do?

when we create new client using sdk.NewClient, it automatically adds the client to engline but at this stage there no sid assigned to the client.

the clients map in engine has all nil keys?

Add client should be done on Join() instead when creating new client?

https://github.com/pion/ion-sdk-go/blob/26d31be8c6027b86740a34f12838c053b1270abd/client.go#L78
https://github.com/pion/ion-sdk-go/blob/master/engine.go#L43

What did you expect?

What happened?

@adwpc
Copy link
Contributor

adwpc commented Dec 2, 2021

new version del engine.
move to ion-sfu load tool

@adwpc adwpc closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants