Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify DefaultNetworkDevice and AdditionalNetworkDevices #185

Open
65278 opened this issue Apr 24, 2024 · 3 comments
Open

Unify DefaultNetworkDevice and AdditionalNetworkDevices #185

65278 opened this issue Apr 24, 2024 · 3 comments
Labels
api break Things that change the API enhancement New feature or request kind/feature
Milestone

Comments

@65278
Copy link
Collaborator

65278 commented Apr 24, 2024

Describe the solution you'd like
At the moment, Network devices are arbitrarily split in two categories, default and additional. This duplicates code and serves no purpose.
If we just have an array of NetworkDevices, and require there to be at least 1, we get the same guarantees.

Anything else you would like to add:

  • IP addresses for the first network device are a problem, because they're coming from the cluster object. This needs some architecture.
  • This changes public API. We'll need to go v1alpha2 and provide migration patches.
@65278 65278 added enhancement New feature or request kind/feature labels Apr 24, 2024
@65278 65278 added this to the v0.5.0 milestone Apr 24, 2024
@wikkyk wikkyk added the api break Things that change the API label Apr 25, 2024
@mcbenjemaa
Copy link
Member

We need to be aware of network devices names,
for instance, the first device must have the name net0

@wikkyk
Copy link
Collaborator

wikkyk commented May 3, 2024

We could stop creating a default gw for every interface at the same time.

@wikkyk
Copy link
Collaborator

wikkyk commented May 3, 2024

ref #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api break Things that change the API enhancement New feature or request kind/feature
Projects
None yet
Development

No branches or pull requests

3 participants