-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The 0.12.12 release changes the interface for dependent projects in a patch release; can it be made 0.13 instead? #286
Comments
Thanks for letting me know. I yanked the release and will re-release as 0.13. |
@ionrock any chance we can get that 0.13 release? it was with great delight that I saw 0.12.12 arrive, imagine my disappointment when it was yanked... |
@ionrock, I just spent a good chunk of time trying to figure out why |
Bump. This is causing headaches in: conda-forge/conda-lock-feedstock#40 (comment) |
There doesn't seem to be any git tag for 0.13 |
There's a bug in the
schema-salad
project now, which depends on:https://github.com/common-workflow-language/schema_salad/blob/774157d065e5ce6bf7669877a25cf2087117cb58/setup.py#L91-L92
Until 0.12.12, if you wanted to use
FileCache
, you were admonished to go installlockfile
as a peer dependency by the resulting error message. The Right Way to useFileCache
seems to have always been to depend onCacheControl[filecache]
, but there's at least this one project that didn't do that, an probably more out there. People seem to have assumed that the fact thatFileCache
needslockfile
specifically was part of its public interface as of the 0.12 release series.With 0.12.12, that interface has changed in a patch release, and dependent projects that assumed that that wouldn't happen are now broken.
Do you want to yank 0.12.12 and renumber it 0.13, since it makes a breaking change to what people took to be the public interface of
FileCache
? Or should people who asked forlockfile
directly and not the extra just have to reap the wages of not reading the docs right?For what it's worth, the docs currently still say
lockfile
is the required module, though they do suggest using the extra:So I'd say it was documented as though the user could rely on that module being the one that was needed.
The text was updated successfully, but these errors were encountered: