Enumerate the history of a document. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a cool idea |
|
I don't know how it increased the spec coverage though. lol |
|
You tested the lines you added. If you have 10 lines with 90% coverage (9 lines covered, 1 missing) and add 5 lines all covered, you've got 14/15 lines tested. It's now 93.3333% covered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ioquatix what do you think about this sort of functionality? Being able to look at all the times a document/object was changed from when it was created to when it gets deleted, I wrote a spec for it too.
You can only see the modifications in the parent branches of the latest commit though.
This is of course completely incapable of detecting when an object has moved/renamed, but I don't see how that situation would arise from the intended use of relaxo.