Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension broken in DuckDuckGo #346

Closed
test6678 opened this issue May 12, 2023 · 16 comments
Closed

Extension broken in DuckDuckGo #346

test6678 opened this issue May 12, 2023 · 16 comments
Assignees
Labels
bug Something isn't working released

Comments

@test6678
Copy link

Blocking search results no longer works in DuckDuckGo. Other search engines (Google, Yandex, etc.) seem to be unaffected.

@bunnyhero
Copy link

just noticed this today too.

@iorate iorate self-assigned this May 14, 2023
@iorate iorate added the bug Something isn't working label May 14, 2023
@ghjb004
Copy link

ghjb004 commented May 16, 2023

Also not working on DuckDuckGo in Safari, I am not sure if this is a separate issue.
Is there a Safari update on the way?

@AnityEx
Copy link

AnityEx commented May 16, 2023

not working on edge, just downloaded toady for this and i come here and see its not working lol

@1Phase1
Copy link

1Phase1 commented May 16, 2023

Can confirm it's not working on DuckDuckGo on Firefox.

@lynnewu
Copy link

lynnewu commented May 17, 2023

Chrome/Windows 10. Same problem. Stopped working with DuckDuckGo sometime in the past week. Working on Google search.

@parapacem
Copy link

DuckDuckGo IMAGE, VIDEO and NEWS all working, not web search though
Yandex browser, have tried two devices both using Windows 10

@MediaEU
Copy link

MediaEU commented May 20, 2023

Is this not strange that no one has at least an assumption why it doesn't work anymore? Debian/Chrome Version 105.0.5195.125 (Official Build) (64-bit)

@bunnyhero
Copy link

if i had to guess, duckduckgo probably changed their CSS or something like that.

@ghjb004
Copy link

ghjb004 commented May 21, 2023

as of today the "block this site" button is showing in the Safari DDG images and videos tabs but not the "all results" tab.
Blocked sites appear to be blocked in those tabs but not in the "all results tab. Can other users can confirm this?

@SaunaThenColdBath
Copy link

@ghjb004 I'm using the extension on Firefox. I confirm the same behavior. The filter is not working on All result tab, and no 'block this site' button. However, the button is shown on Images, News, Video tab.

@KirkH420
Copy link

Not working for me in on DDG either.

@lilibyte
Copy link

lilibyte commented Jun 1, 2023

The search engine handler duckduckgo.ts defines target: '.results > .nrn-react-div' but I don't see .results or .nrn-react-div in the duckduckgo search result HTML. I think this should be replaced with target: '.react-results--main'

edit: hm if I understand what the source is doing correctly, maybe it should actually be
.react-results--main article[data-testid="result"] instead since that matches the card for the result itself.

@ghjb004
Copy link

ghjb004 commented Jun 2, 2023

iorate様 お願い致します!

@iorate iorate closed this as completed in aa00276 Jun 3, 2023
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

🎉 This issue has been resolved in version 8.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Jon-guy30
Copy link

Jon-guy30 commented Jun 5, 2023

This extension is not updated in firefox AMO. Is the 8.3.1 version going to be released there? I just installed this extension, it installed the broken 8.3.0 version, is Firerfox going to get the 8.3.1 version? Chrome says it has the 8.3.1 release.

Thanks for the update!

@ghjb004
Copy link

ghjb004 commented Jun 6, 2023

Just installed the Safari update. Many thanks, working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests