Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Improve gas estimation for layer2 #7464

Closed
3 of 6 tasks
msarcev opened this issue Sep 27, 2023 · 0 comments · Fixed by #7604
Closed
3 of 6 tasks

[Task]: Improve gas estimation for layer2 #7464

msarcev opened this issue Sep 27, 2023 · 0 comments · Fixed by #7604
Assignees
Labels
type:enhancement Enhancement to existing feature

Comments

@msarcev
Copy link
Collaborator

msarcev commented Sep 27, 2023

Task description

Improve gas estimation for layer2 transactions

Use gasBurned retrieved from "estimatedgas" endpoint to update the gasBudget field in metadata.
The gasBudget should be set to gasBurned + 1. The "1" is needed for it to work, some optimization they have in wasp.

i.e.
metadata = getLayer2MetadataForTransfer(transactionDetails, gasEstimatePayload.gasBurned + 1)

Requirements

  • Improve the gasBudget by using the gasBurned
  • Add 1 grain of salt to it
  • Leave a comment to explain the magic "1"

Creation checklist

  • I have assigned this task to the correct people
  • I have added the most appropriate labels
  • I have linked the correct milestone and/or project
@msarcev msarcev added the type:enhancement Enhancement to existing feature label Sep 27, 2023
@begonaalvarezd begonaalvarezd assigned marc2332 and unassigned msarcev Oct 13, 2023
@marc2332 marc2332 linked a pull request Oct 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement to existing feature
Projects
Status: 🎉 Done
Development

Successfully merging a pull request may close this issue.

3 participants