Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Find a new tool for license header checks #921

Closed
olivereanderson opened this issue Jun 23, 2022 · 2 comments · Fixed by #1022
Closed

[Task] Find a new tool for license header checks #921

olivereanderson opened this issue Jun 23, 2022 · 2 comments · Fixed by #1022
Assignees
Labels
Chore Tedious, typically non-functional change
Milestone

Comments

@olivereanderson
Copy link
Contributor

Description

The unstable license_template_path from rustfmt was removed in this PR. Since we rely on this option a replacement will have to be found.

@grtlr is working on cargo-license-template which is intended to provide comparable functionality, however it is not yet ready to be used for identity.rs as it currently errors on .rs files in the target directories of sub-projects (such as bindings/stronghold-nodejs). @grtlr is aware of this issue and will hopefully soon be able to solve it and we can of course also offer to help.

@olivereanderson olivereanderson added this to the v0.7 Features milestone Jun 23, 2022
@olivereanderson olivereanderson added the Chore Tedious, typically non-functional change label Jun 23, 2022
@grtlr
Copy link

grtlr commented Jun 24, 2022

I've just release version v0.1.3 which includes the functionality to ignore files via an --ignore flag and a .gitignore-like file:

cargo license-template --template .license_template --ignore .license_template_ignore --verbose

I will soon start to transition to tool to be independent from cargo and rather make it completely self-contained. The next step would be to offer a convenient GitHub Action that does not require building the tool from scratch every time we run CI.

@cycraig
Copy link
Contributor

cycraig commented Jul 5, 2022

Fantastic. With v0.1.3 it suffices to add a .license_template_ignore file to ignore the libjose fixtures for now.

libjose/tests/fixtures/

Alternatively a change similar to #917 could be applied for the following files:

libjose/tests/fixtures/rfc7797.rs ... failed
libjose/tests/fixtures/rfc8037_ed25519.rs ... failed
libjose/tests/fixtures/rfc7518.rs ... failed
libjose/tests/fixtures/rfc7638.rs ... failed
libjose/tests/fixtures/rfc8037_x448.rs ... failed
libjose/tests/fixtures/rfc8037_x25519.rs ... failed
libjose/tests/fixtures/rfc7516.rs ... failed
libjose/tests/fixtures/rfc7517.rs ... failed
libjose/tests/fixtures/rfc7515.rs ... failed

Either way we should add cargo-license-template to GitHub Actions.

@cycraig cycraig mentioned this issue Sep 8, 2022
10 tasks
@cycraig cycraig self-assigned this Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tedious, typically non-functional change
Projects
Development

Successfully merging a pull request may close this issue.

3 participants