Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): revert axum upgrade #1021

Merged
merged 1 commit into from Jan 10, 2023
Merged

fix(api): revert axum upgrade #1021

merged 1 commit into from Jan 10, 2023

Conversation

DaughterOfMars
Copy link
Collaborator

@DaughterOfMars DaughterOfMars commented Jan 9, 2023 •
edited by grtlr

Linked Issues

Notes to Reviewer

As a reviewer, please pay particular attention to the following areas when reviewing this PR and tick the above boxes after you have completed the steps.

API Changes

  • Test the API endpoints which were added/changed.
  • Check for breaking changes in the API and matching (conventional) commit message prefix.
  • Ensure that the axum endpoints no longer leak memory.

@grtlr grtlr merged commit 761a4f2 into main Jan 10, 2023
@grtlr grtlr deleted the fix/api/revert-axum-0.6 branch January 10, 2023 08:08
@DaughterOfMars DaughterOfMars mentioned this pull request Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grtlr grtlr grtlr approved these changes

@Alex6323 Alex6323 Alex6323 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recursive memory allocation related to BTreeMap in custom router
3 participants
@DaughterOfMars @grtlr @Alex6323