Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(analytics): only calculate analytics after chronicle is synced #1065

Merged
merged 6 commits into from Jan 25, 2023
Merged

fix(analytics): only calculate analytics after chronicle is synced #1065

merged 6 commits into from Jan 25, 2023

Conversation

DaughterOfMars
Copy link
Collaborator

@DaughterOfMars DaughterOfMars commented Jan 23, 2023 •
edited by grtlr

Notes to Reviewer

As a reviewer, please pay particular attention to the following areas when reviewing this PR and tick the above boxes after you have completed the steps.

INX Changes

  • Run chronicle using an INX connection.
  • Ensure that restarting does not change the start milestone.

Database Changes

  • Review database queries for correctness/conciseness.
  • Ensure queries are supported by indexes if needed.
  • Check for breaking changes in the data model and matching (conventional) commit message prefix.

grtlr
grtlr previously approved these changes Jan 24, 2023
View reviewed changes
@DaughterOfMars DaughterOfMars mentioned this pull request Jan 24, 2023
Closed
@grtlr grtlr merged commit 3568cfe into main Jan 25, 2023
@grtlr grtlr deleted the fix/analytics/calc-after-sync branch January 25, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex6323 Alex6323 Alex6323 left review comments

@grtlr grtlr grtlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DaughterOfMars @grtlr @Alex6323