Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db): fix slow get block children query #1158

Merged
merged 5 commits into from Mar 2, 2023
Merged

fix(db): fix slow get block children query #1158

merged 5 commits into from Mar 2, 2023

Conversation

Alex6323
Copy link
Collaborator

@Alex6323 Alex6323 commented Mar 1, 2023 •
edited

Linked Issues

Notes to Reviewer

As a reviewer, please pay particular attention to the following areas when reviewing this PR and tick the above boxes after you have completed the steps.

API Changes

  • Test the API endpoints which were added/changed.
  • Ensure that the API response times scale with database size appropriately.

Test cases

  • Review and run tests that were added/changed.

Database Changes

  • Review database queries for correctness/conciseness.
  • Ensure queries are supported by indexes if needed.

@Alex6323 Alex6323 marked this pull request as ready for review March 1, 2023 17:00
@Alex6323 Alex6323 merged commit 587e9ab into main Mar 2, 2023
@Alex6323 Alex6323 deleted the fix/db/slow-get-block-children-query branch March 2, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block Children query is too slow
2 participants
@Alex6323 @DaughterOfMars