Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): improve feature handling and CI #428

Merged
merged 18 commits into from Jul 15, 2022
Merged

fix(ci): improve feature handling and CI #428

merged 18 commits into from Jul 15, 2022

Conversation

Alex6323
Copy link
Collaborator

@Alex6323 Alex6323 commented Jul 13, 2022 •
edited

Closes #358
Closes #179

grtlr
grtlr reviewed Jul 13, 2022
View reviewed changes
.cargo/config.toml Outdated Show resolved Hide resolved
@grtlr grtlr linked an issue Jul 13, 2022 that may be closed by this pull request
Test feature combination in canary.yml CI #179
Closed
@grtlr grtlr changed the title fix(build): fix stardust feature deps; Add 'check-all-features' to canary fix(ci): improve feature handling and CI Jul 13, 2022
@grtlr
Copy link
Contributor

grtlr commented Jul 14, 2022

Can you also please unify all api-* features under a single api?

@Alex6323 Alex6323 force-pushed the main-fix-each-feature-compilation branch from 7f210db to 9cf0535 Compare July 14, 2022 11:19
@grtlr grtlr mentioned this pull request Jul 14, 2022
Closed
grtlr
grtlr reviewed Jul 14, 2022
View reviewed changes
bin/inx-chronicle/src/api/routes.rs Outdated Show resolved Hide resolved
src/db/collections/ledger_update.rs Outdated Show resolved Hide resolved
@Alex6323 Alex6323 force-pushed the main-fix-each-feature-compilation branch from c4fe7b2 to 4733e7b Compare July 14, 2022 21:43
grtlr
grtlr approved these changes Jul 15, 2022
View reviewed changes
bin/inx-chronicle/src/api/routes.rs Outdated Show resolved Hide resolved
@grtlr grtlr merged commit 633767d into iotaledger:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaughterOfMars DaughterOfMars DaughterOfMars left review comments

@grtlr grtlr grtlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation fails with --no-default-features option Test feature combination in canary.yml CI
3 participants
@Alex6323 @grtlr @DaughterOfMars