chore(db)!: direct dto conversion #752

DaughterOfMars · 2022-09-28T18:06:42Z

Closes #733

grtlr

I think we will have to wipe the database with the changes to the MilestoneEssence, or provide some mitigation logic. Any thoughts?

Please adapt the PR title accordingly.

src/types/stardust/block/payload/milestone/mod.rs

Co-authored-by: Jochen Görtler <grtlr@users.noreply.github.com>

DaughterOfMars added 2 commits September 28, 2022 12:33

Impl into dtos for db types

454cc52

Update bee to access remaining dtos. Fix clippy lints.

cf189de

DaughterOfMars requested review from grtlr and Alex6323 September 28, 2022 18:06

Remove serde feature from bee-block

2f7b00b

grtlr suggested changes Sep 29, 2022

View reviewed changes

src/types/stardust/block/payload/milestone/mod.rs Show resolved Hide resolved

DaughterOfMars changed the title ~~chore(db): direct dto conversion~~ chore(db)!: direct dto conversion Sep 29, 2022

grtlr previously approved these changes Sep 29, 2022

View reviewed changes

src/types/stardust/block/payload/milestone/mod.rs Outdated Show resolved Hide resolved

Update src/types/stardust/block/payload/milestone/mod.rs

9a89caf

Co-authored-by: Jochen Görtler <grtlr@users.noreply.github.com>

DaughterOfMars dismissed grtlr’s stale review via 9a89caf September 29, 2022 14:11

grtlr approved these changes Sep 29, 2022

View reviewed changes

grtlr merged commit ce584ac into main Sep 29, 2022

grtlr deleted the chore/db/direct-dto-conversion branch September 29, 2022 14:23

Provide feedback