Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db): improve performance of analytics queries #900

Merged
merged 20 commits into from Nov 25, 2022
Merged

fix(db): improve performance of analytics queries #900

merged 20 commits into from Nov 25, 2022

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Nov 17, 2022 •
edited by Alex6323

Notes to Reviewer

As a reviewer, please pay particular attention to the following areas when reviewing this PR and tick the above boxes after you have completed the steps.

INX Changes

  • Run chronicle using an INX connection.

Database Changes

  • Review database queries for correctness/conciseness.
  • Ensure queries are supported by indexes if needed.
  • Check for breaking changes in the data model and matching (conventional) commit message prefix.

@grtlr grtlr marked this pull request as draft November 17, 2022 13:57
@grtlr grtlr marked this pull request as ready for review November 21, 2022 16:13
@grtlr grtlr assigned grtlr and unassigned grtlr Nov 22, 2022
@Alex6323
Copy link
Collaborator

Tests showed no performance improvements.

@grtlr grtlr merged commit 48a74a1 into main Nov 25, 2022
@grtlr grtlr deleted the fix/db/ledger-state-index branch November 25, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaughterOfMars DaughterOfMars DaughterOfMars left review comments

@Alex6323 Alex6323 Alex6323 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grtlr @Alex6323 @DaughterOfMars