Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logging): set up logging before subcommands are executed #927

Merged
merged 1 commit into from Nov 23, 2022
Merged

fix(logging): set up logging before subcommands are executed #927

merged 1 commit into from Nov 23, 2022

Conversation

Alex6323
Copy link
Collaborator

@Alex6323 Alex6323 commented Nov 23, 2022 •
edited by grtlr

Notes to Reviewer

As a reviewer, please pay particular attention to the following areas when reviewing this PR and tick the above boxes after you have completed the steps.

Config Changes

  • Ensure proper order in which CLI and config arguments are applied.

shufps
shufps reviewed Nov 23, 2022
View reviewed changes
Copy link

@shufps shufps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😊

@Alex6323 Alex6323 changed the title Set up logging before subcommands are executed fix(logging): set up logging before subcommands are executed Nov 23, 2022
@grtlr grtlr merged commit 7464781 into main Nov 23, 2022
@grtlr grtlr deleted the fix/logging/move-logging-setup branch November 23, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shufps shufps shufps left review comments

@grtlr grtlr grtlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Alex6323 @shufps @grtlr