Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BlockFailureReason #679

Closed
PhilippGackstatter opened this issue Feb 2, 2024 · 0 comments · Fixed by #689
Closed

Refactor BlockFailureReason #679

PhilippGackstatter opened this issue Feb 2, 2024 · 0 comments · Fixed by #689
Assignees
@PhilippGackstatter
Labels
team-node Issues for the Node Team
Milestone
v1.0.0-beta

Comments

@PhilippGackstatter
Copy link
Contributor

PhilippGackstatter commented Feb 2, 2024 •
edited

Refactor BlockFailureReason.

  • iotago.ErrBlockVersionInvalid is currently part of the map, but never returned from anyhwere.
  • BlockFailureParentInvalid is part of the reasons, but not the target of any mapping.
  • Multiple errors map to BlockFailureAccountInvalid, but we should consider being more developer-friendly and create dedicated failure reasons for each error.
  • There is also the unsed BlockFailureOrphanedDueNegativeCreditsBalance with a leftover TODO.

Also remove the iotago.ErrNestedMultiUnlock mapping and the corresponding TX failure reason. It cannot actually be returned in the VM since we already check for nested multi unlocks during the syntactic validation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippGackstatter PhilippGackstatter

Labels
team-node Issues for the Node Team
Projects
iota-core
Archived in project
Milestone
v1.0.0-beta
Development

Successfully merging a pull request may close this issue.

Block failure reason improvements iotaledger/iota.go
1 participant
@PhilippGackstatter