Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

adds milestone request to message protocol #1829

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

acha-bill
Copy link
Contributor

Description

Adds MS_REQUEST to message protocol.

Fixes #1793

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • Existing unit tests pass
  • Added new tests

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@acha-bill acha-bill requested a review from kwek20 April 7, 2020 19:40
@@ -123,6 +128,15 @@ public static ByteBuffer createHeartbeatPacket(Heartbeat heartbeat) {
return buf;
}

public static ByteBuffer createMilestoneRequestPacket(MilestoneRequest milestoneRequest){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -6,16 +6,13 @@
import com.iota.iri.network.neighbor.Neighbor;
import com.iota.iri.network.neighbor.NeighborState;
import com.iota.iri.network.pipeline.TransactionProcessingPipeline;
import com.iota.iri.network.protocol.Handshake;
import com.iota.iri.network.protocol.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Milestone Request to message protocol
2 participants