-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: REST Node API #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wusyong
reviewed
Sep 11, 2020
wusyong
reviewed
Sep 11, 2020
This comment has been minimized.
This comment has been minimized.
luca-moser
requested changes
Sep 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I believe we should rename
/transaction-messages
to just/transactions
. For example, routes like/transaction-messages/by-address
include the wordmessages
for no apparent reason. - post examples still use
post-
where they should beget-
- Responses should return array of objects instead of objects where each sub object is keyed by the identifier of the particular entity.
- I am not sure whether the
peers
count in the/info
response is useful information. - The API does not describe any kind of authentication mechanism which I believe at the end we should have, perhaps something simple like a JWT.
alexsporn
reviewed
Sep 22, 2020
luca-moser
requested changes
Sep 23, 2020
luca-moser
requested changes
Sep 23, 2020
obany
reviewed
Mar 2, 2021
obany
reviewed
Mar 2, 2021
obany
reviewed
Mar 2, 2021
obany
reviewed
Mar 2, 2021
…t in example, fix address type in MigratedFundsEntry, messageId -> milestoneHash
Thoralf-M
reviewed
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered