Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Missing application icon #821

Closed
lukisi opened this issue Dec 17, 2018 · 12 comments · Fixed by #1322, #1581 or #1590
Closed

Missing application icon #821

lukisi opened this issue Dec 17, 2018 · 12 comments · Fixed by #1322, #1581 or #1590
Assignees
Labels
C - Desktop E - UI/UX Epic - Improving user interface/user experience L - Has PR P - Linux Platform - Specifically relates to Linux T - Bug Type - Bug: Something isn't working

Comments

@lukisi
Copy link

lukisi commented Dec 17, 2018

Bug description

The IOTA/Trinity icon is not shown for the app in the dash (of Gnome Shell)

Environment Specs

Laptop

  • Manufacturer: Dell
  • Model: XPS
  • OS version: Ubuntu 18.04

Trinity

  • Trinity version: 0.4.5

Steps To Reproduce

  1. Open the dash, search for trinity

Expected behaviour

The app with the correct icon should be in the results.

Actual behaviour

The app appears with the default executable icon.

Am I planning to do it myself with a PR?

No.

@rajivshah3
Copy link
Member

Can you post a screenshot of what icon is shown instead of the Trinity icon?

@rajivshah3 rajivshah3 added C - Desktop P - Linux Platform - Specifically relates to Linux labels Dec 17, 2018
@lukisi
Copy link
Author

lukisi commented Dec 18, 2018

trinity-shot

@rajivshah3
Copy link
Member

@lukisi is the default icon showing in the dock as well when Trinity is running? Or does the IOTA logo appear there?

@rajivshah3 rajivshah3 added the L - Need more information Lifecycle - Waiting for more information label Dec 25, 2018
@lukisi
Copy link
Author

lukisi commented Dec 26, 2018

When Trinity is running the default icon is showing in the dock as well.

@rajivshah3 rajivshah3 removed the L - Need more information Lifecycle - Waiting for more information label Dec 27, 2018
@rajivshah3
Copy link
Member

rajivshah3 commented Dec 27, 2018

@rihardsgravis would this be fixed by adding the icon path to the icon field as shown in the electron-builder docs? It says it converts the macOS icon by default but I guess that's not occurring for some reason. I don't have an Ubuntu VM so I can't really test this

@KeithSSmith
Copy link

I was having this same issue where the Trinity Icon would not show up when searching through applications or in the dock (broken link). I was able to fix these by doing the following:

Fix Default Icon while searching apps (Download trinity.png from GitHub icons):
Edit: /home/[user]/.local/share/applications/appimagekit-trinity-desktop.desktop
Add: Icon=/opt/trinity/trinity.png

Fix Broken Link in Doc while running:
Edit: /home/[user]/.local/share/applications/appimagekit-trinity-desktop.desktop
Add: StartupWMClass=Trinity

@rajivshah3
Copy link
Member

rajivshah3 commented Dec 28, 2018

Thanks for that info @KeithSSmith . Without those edits, does appimagekit-trinity-desktop.desktop look like this? If so, it seems like an icon isn’t being included when the app is packaged

@KeithSSmith
Copy link

KeithSSmith commented Dec 28, 2018

Just did a fresh install of Ubuntu 18.04.1 with updates and upgrades, the icons in search and in dock are still showing the default icon. The appimagekit-trinity-desktop.desktop file looks like this (doesn't match the link you posted):

[Desktop Entry]
Name=Trinity
Comment=Desktop wallet for IOTA
Exec="/home/iota/Desktop/trinity-desktop-0.4.6.AppImage" %U
Terminal=false
Type=Application
Icon=appimagekit-trinity-desktop
StartupWMClass=Trinity
X-AppImage-Version=0.4.6
Categories=Office;Finance;
MimeType=x-scheme-handler/iota;
X-AppImage-BuildId=1EfAck1It2wrL3IZU6EUxZi1iru
X-Desktop-File-Install-Version=0.23
X-AppImage-Comment=Generated by /tmp/.mount_trinitRBi1DO/AppRun
TryExec=/home/iota/Desktop/trinity-desktop-0.4.6.AppImage

@rajivshah3
Copy link
Member

rajivshah3 commented Dec 28, 2018

Thanks @KeithSSmith

Icon=appimagekit-trinity-desktop

Looks like this needs to be set during packaging. I think specifying it in the electron-builder config should fix it

@rajivshah3 rajivshah3 added T - Bug Type - Bug: Something isn't working E - UI/UX Epic - Improving user interface/user experience labels Dec 28, 2018
@vincenzopalazzo
Copy link

@rajivshah3 Hello, I noticed the equal problem in gitkraken, the icon not viasualizzed in the docky, could it be an Electron problem?

@lukisi
Copy link
Author

lukisi commented May 13, 2019

Trinity 0.5.0 still has same problem. I tried both an update (via the menu in app) and a fresh install on another computer.

@vincenzopalazzo
Copy link

@lukisi I have same problem but I resolved with this code

  • Edit: /home/[user]/.local/share/applications/appimagekit-trinity-desktop.desktop

In the file edit a path for the image, I have downloaded the image for project github

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Desktop E - UI/UX Epic - Improving user interface/user experience L - Has PR P - Linux Platform - Specifically relates to Linux T - Bug Type - Bug: Something isn't working
Projects
None yet
6 participants