Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache participation data for spent outputs #1866

Closed
Thoralf-M opened this issue Feb 16, 2023 · 0 comments · Fixed by #1953
Closed

Cache participation data for spent outputs #1866

Thoralf-M opened this issue Feb 16, 2023 · 0 comments · Fixed by #1953
Assignees
Labels
core Rust core t-impl Task - Implementation
Milestone

Comments

@Thoralf-M
Copy link
Member

Description

Currently all outputs are requested

let outputs = self.outputs(None).await?;

If an output was spent, there should only be one more request to get the latest state and then its data shouldn't be requested anymore

Motivation

If an output is spent, it stops participating from that point on, so its participation can't change anymore and all future requests would only return the same data and are wasted

Requirements

  1. If an output is spent, request its participation data one last time to get the latest state and cache it
  2. If its cached, don't request it anymore, but merge the cached participation data with the current ones

Are you planning to do it yourself in a pull request?

No.

@Thoralf-M Thoralf-M added the task label Feb 16, 2023
@Thoralf-M Thoralf-M added this to the v1.0.0 milestone Feb 16, 2023
@thibault-martinez thibault-martinez modified the milestones: v1.0.0, v1.1.0 Mar 5, 2023
@thibault-martinez thibault-martinez added core Rust core t-impl Task - Implementation and removed task labels Mar 9, 2023
@Thoralf-M Thoralf-M self-assigned this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Rust core t-impl Task - Implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants