Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing constructor IOTAppStory with Appname and Version #74

Closed
Bolukan opened this issue Sep 16, 2018 · 12 comments
Closed

Missing constructor IOTAppStory with Appname and Version #74

Bolukan opened this issue Sep 16, 2018 · 12 comments

Comments

@Bolukan
Copy link
Contributor

Bolukan commented Sep 16, 2018

In examples the IOTAppStory object is initiated with the command:
IOTAppStory IAS(APPNAME, VERSION, COMPDATE, MODEBUTTON);

However, the current version of IOTAppStory got only the constructor for
IOTAppStory IAS(COMPDATE, MODEBUTTON);, see Line 228
and functions for preSetAppName and preSetAppVersion.

@Onno-Dirkzwager
Copy link
Collaborator

Bolukan can you point out which examples, because I just had a look at all the new examples that come with the 2.0.0 library and cannot find the old: IOTAppStory IAS(APPNAME, VERSION, COMPDATE, MODEBUTTON);

@Bolukan
Copy link
Contributor Author

Bolukan commented Sep 16, 2018

You are right. This only can be seen in PlatformIO. The 2.0.0 version is from 6 months ago, according to PlatformIO. Maybe PlatformIO updates only the files (in their cache) if the version has been updated?
I will do some research how PlatformIO is updated.

https://platformio.org/lib/show/1704/IOTAppStory-ESP

@Bolukan
Copy link
Contributor Author

Bolukan commented Sep 16, 2018

https://docs.platformio.org/en/latest/librarymanager/config.html

PlatformIO Library Crawler uses library.json manifest to extract source code from developer’s location and keeps a cleaned library in own Library Registry.

@Onno-Dirkzwager
Copy link
Collaborator

Ah we started prepairing this release +/- 6 months ago.
So PIO pickt up that change directly from the json file in the master. Instead of Arduino lib manager that only looks at the releases. Good to know and thankyou for pointing that out.

@Onno-Dirkzwager
Copy link
Collaborator

So to help the PIO users I think the easiest thing we can do is bump up the version number to lets say 2.0.01
Do you agree and more important could you test this for us?

@Bolukan
Copy link
Contributor Author

Bolukan commented Sep 16, 2018

That seems the most effective way. I will be glad to report back the behaviour in PlatformIO.

Issue #75 is also specific PlatformIO behaviour that blocks current use. Next to some warnings I succeeded uploading and using my first IotAppStory Project/App/Device combination.

@Onno-Dirkzwager
Copy link
Collaborator

Onno-Dirkzwager commented Sep 17, 2018

Bolukan,
i updated the json file as discussed. Maby you can let us know if your examples get updated?
b609bb6

@Bolukan
Copy link
Contributor Author

Bolukan commented Sep 18, 2018

No effect. I guess library.json should be changed instead of library.properties
See https://docs.platformio.org/en/latest/librarymanager/config.html#version

@Onno-Dirkzwager
Copy link
Collaborator

2.0.01 Done! Keep in mind that we will update to 2.0.1 in the near future. This update will include among other things your other issues.

@Bolukan
Copy link
Contributor Author

Bolukan commented Sep 18, 2018

Manifest changed but examples did yet not change. I will check again after 24 hours ....

@Bolukan
Copy link
Contributor Author

Bolukan commented Sep 19, 2018

No change. Platformio users can retrieve their examples from github. I will wait till 2.0.1 is released

@Bolukan
Copy link
Contributor Author

Bolukan commented Sep 19, 2018

19-09-2019 19:00 CEST PlatformIO recognize v2.0.01.
Almost all examples are updated - at least I checked they have the right constructor - only WebAppToggleBtn is still old at this moment, it you look to the examples in the browser. In the TAR download the right version is available.
For me this issue can be closed.

@Bolukan Bolukan closed this as completed Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants