Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make genesis block creation be independent of address and signature #129

Closed
zjshen14 opened this issue Oct 1, 2018 · 1 comment
Closed

Make genesis block creation be independent of address and signature #129

zjshen14 opened this issue Oct 1, 2018 · 1 comment
Assignees
@MrAngelll
Labels
bettereng Better engineering quality

Comments

@zjshen14
Copy link
Contributor

zjshen14 commented Oct 1, 2018

testnet_actions.yaml defines the actions to be included in the genesis block (genesis.go). The pain point of using this is that every time we update the action struct or the address, we have to re-generate the config file again. However, if we keep to only use pub key for src/dst, generate address and signature dynamically. We should be able to get rid of always updating the file.
@zjshen14 zjshen14 added the bettereng Better engineering quality label Oct 1, 2018
@zjshen14
Copy link
Contributor Author

zjshen14 commented Oct 7, 2018

#157

@zjshen14 zjshen14 closed this as completed Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAngelll MrAngelll

Labels
bettereng Better engineering quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrAngelll @zjshen14