Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Add in-browser (karma) tests for local and CI #6

Closed
ethanfrey opened this issue Oct 5, 2018 · 6 comments
Closed

Add in-browser (karma) tests for local and CI #6

ethanfrey opened this issue Oct 5, 2018 · 6 comments
Labels
blocked Blocked on external dependency ready PO validated, dev reviewed, all requirements met to pull into sprint

Comments

@ethanfrey
Copy link
Contributor

Extend the existing test cases to work in the browser using karma (or other tool)

@ethanfrey ethanfrey added this to the Simplest Proof of Concept milestone Oct 5, 2018
@ethanfrey ethanfrey added this to To do in Development - Demo Wallet 📯 via automation Oct 5, 2018
@ethanfrey
Copy link
Contributor Author

This may be an alternative if we stick with the react-standard jest testing framework, as karma needs mocha/chai or jasmine.

https://itnext.io/testing-your-javascript-in-a-browser-with-jest-puppeteer-express-and-webpack-c998a37ef887

I'd love to hear of other options

@ethanfrey
Copy link
Contributor Author

ethanfrey commented Oct 8, 2018

It seems must sample react code uses jest, but puppeteer only gives super high level visibility (check html or rendered page). Nothing like running the unit tests in the browser environment. https://github.com/smooth-code/jest-puppeteer

It seems this will not be done either: jestjs/jest#139 and I guess Facebook has a huge QA department to deal with all the browser quirks

@ethanfrey
Copy link
Contributor Author

Moving this to later, as we cannot get full test suite, enough to sort out bugs, without facuet in the CI.

1 similar comment
@ethanfrey
Copy link
Contributor Author

Moving this to later, as we cannot get full test suite, enough to sort out bugs, without facuet in the CI.

@ethanfrey
Copy link
Contributor Author

Blocked on iov-core faucet v0.8.0 integration

@ethanfrey ethanfrey added ready PO validated, dev reviewed, all requirements met to pull into sprint blocked Blocked on external dependency labels Nov 7, 2018
@ethanfrey
Copy link
Contributor Author

Will use jest, no more karma possible

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked Blocked on external dependency ready PO validated, dev reviewed, all requirements met to pull into sprint
Projects
None yet
Development

No branches or pull requests

1 participant