Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve high-level benchmarks, sending coins with fees at abci level #408

Closed
ethanfrey opened this issue Mar 15, 2019 · 4 comments · Fixed by #410
Closed

Improve high-level benchmarks, sending coins with fees at abci level #408

ethanfrey opened this issue Mar 15, 2019 · 4 comments · Fixed by #410
Assignees

Comments

@ethanfrey
Copy link
Contributor

ethanfrey commented Mar 15, 2019

Followup story #284

@husio
Copy link
Contributor

husio commented Mar 15, 2019

Initial work is in https://github.com/iov-one/weave/tree/benchmarks_on_real_bnsd branch. It appears to be harder to write than initially expected.
For now, waiting for the development of #375 I think that having a bnsd client would make this task much easier.

@ethanfrey
Copy link
Contributor Author

Please take the time to refactor the abci level benchmarks well. Especially to consider the api you want. I think we made huge progress on adding clarity this morning.

Writing over tendermint is harder than directly on the app, but we would like to expose a similar interface. And would need to add more features as well.

Once we get clarity on apis from this refactoring, we will be much clearer on what we want from a client

@husio husio self-assigned this Mar 15, 2019
@ethanfrey
Copy link
Contributor Author

🎉

@husio
Copy link
Contributor

husio commented Mar 20, 2019

Slowly getting "there" with the tests 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants