Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weave package improvements #492

Closed
5 tasks done
ruseinov opened this issue Apr 4, 2019 · 1 comment · Fixed by #634
Closed
5 tasks done

weave package improvements #492

ruseinov opened this issue Apr 4, 2019 · 1 comment · Fixed by #634
Assignees
@ruseinov

Comments

@ruseinov
Copy link
Contributor

ruseinov commented Apr 4, 2019 •
edited

- [ ] TODO: GasPayment, check if this could already be implemented Still not there

  • Nicer log modification, maybe use fmt instead of concat
  • Instead of just checking code != 0 use a const for more descriptiveness on what's happening (code 0 reserved for non-errors)
  • hex.go is empty, shall we ditch it? -> yes
  • LoadVersion to be implemented (see historical queries)
  • version.go does not seem to be useful -> we override it in the Makefile I believe, but int versions not used

Other related issues:
@ethanfrey
Copy link
Contributor

I added comments above. Three are larger tasks in other issues. The rest nice things to clean up

@ethanfrey ethanfrey mentioned this issue Apr 5, 2019
Closed
31 tasks
@ruseinov ruseinov self-assigned this May 16, 2019
@ruseinov ruseinov mentioned this issue May 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruseinov ruseinov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

weave: package improvements iov-one/weave
2 participants
@ruseinov @ethanfrey