Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove call to deprecated bpf_detach_kfunc helper #1391

Merged
merged 2 commits into from Jun 22, 2020
Merged

Remove call to deprecated bpf_detach_kfunc helper #1391

merged 2 commits into from Jun 22, 2020

Conversation

willfindlay
Copy link
Contributor

As per discussion in iovisor/bcc#2979, the bpf_detach_kfunc function has been removed from libbcc, as it was effectively a NOP. This pull request removes the call to bpf_detach_kfunc from bpftrace's AttachedProbe::detach_kfunc in order to make bpftrace work with the latest bcc release.

Checklist
  • Language changes are updated in docs/reference_guide.md
  • User-visible and non-trivial changes updated in CHANGELOG.md

danobi
danobi approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@danobi danobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@danobi danobi merged commit b7a8159 into bpftrace:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmisono mmisono mmisono left review comments

@danobi danobi danobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@willfindlay @mmisono @danobi